Re: [PATCH 12/23] mpt3sas: switch to using ->device_configure

[Bart Van Assche <bvanassche@xxxxxxx>]

On 4/3/24 00:08, Hannes Reinecke wrote:
> On 4/2/24 15:06, Christoph Hellwig wrote:
> > @@ -2687,8 +2686,7 @@ scsih_slave_configure(struct scsi_device *sdev)
> >            **/
> >           blk_queue_flag_set(QUEUE_FLAG_NOMERGES,
> >                   sdev->request_queue);
> > -        blk_queue_virt_boundary(sdev->request_queue,
> > -                ioc->page_size - 1);
> > +        lim->virt_boundary_mask = ioc->page_size - 1;
> >           return 0;
> >       }
> Here the same argument as done for the previous patch could be made; if 
> we had the possibility to set NOMERGES in the queue limits we could do 
> away with the reference to the request queue here.

Another possibility is to remove all code from drivers that sets
QUEUE_FLAG_NOMERGES. I agree with Christoph that drivers shouldn't set
that flag.

Thanks,

Bart.