On Mon, Sep 24, 2007 at 08:25:28PM -0400, Jeff Garzik wrote: > >OK, we've had these competing patch sets floating around for two months > >now. Christoph and Jeff, can we get agreement on which is going in? > > Well, my opinion is > > 1) When judging by total amount of positive improvement, Christoph's > patches are superior -- he has more overall cleanups than I do. > > 2) When judging by likelihood of inducing breakage, I feel my changes > are superior. My gdth changes tightly adhere to the > equivalent-transformation method of shuffing code around, enabling > further improvements. IOW, I resisted the urge to make cleanups and fix > insignificant, pre-existing bugs during the transformations. > > 3) I am utterly unmotivated to merge the two patchsets. Someone should > make an executive decision, pull one patchset, and drop the other. My > coding "mood" has swung from cleaning up code to writing new SAS drivers :) Go ahead with your patches as I don't have time working on mine right now. I'll port them ontop of your patches when I get time for it. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html