James Bottomley wrote:
On Sat, 2007-07-21 at 16:34 -0400, Jeff Garzik wrote:
This is the rest of the stuff checked into the 'gdth' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git
As noted before, I'm fine with Christoph's gdth work superceding mine,
or whatever. This was just me poking around. Hopefully the patches
are useful for illustration, if nothing else.
1) [SCSI] gdth: kill gdth_{read,write}[bwl] wrappers
2) [SCSI] gdth: Move probe-time error handling code to end of each function
3) [SCSI] gdth: make some virt ctrlr code common; shuffle SHT members
4) [SCSI] gdth: convert to modern SCSI host alloc/scan
OK, we've had these competing patch sets floating around for two months
now. Christoph and Jeff, can we get agreement on which is going in?
Well, my opinion is
1) When judging by total amount of positive improvement, Christoph's
patches are superior -- he has more overall cleanups than I do.
2) When judging by likelihood of inducing breakage, I feel my changes
are superior. My gdth changes tightly adhere to the
equivalent-transformation method of shuffing code around, enabling
further improvements. IOW, I resisted the urge to make cleanups and fix
insignificant, pre-existing bugs during the transformations.
3) I am utterly unmotivated to merge the two patchsets. Someone should
make an executive decision, pull one patchset, and drop the other. My
coding "mood" has swung from cleaning up code to writing new SAS drivers :)
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
