> On 3/26/24 01:32, Avri Altman wrote:
> > @@ -992,10 +976,6 @@ EXPORT_SYMBOL_GPL(ufshcd_is_hba_active);
> >
> > u32 ufshcd_get_local_unipro_ver(struct ufs_hba *hba)
> > {
> > - /* HCI version 1.0 and 1.1 supports UniPro 1.41 */
> > - if (hba->ufs_version <= ufshci_version(1, 1))
> > - return UFS_UNIPRO_VER_1_41;
> > - else
> > return UFS_UNIPRO_VER_1_6;
> > }
>
> Please fix the indentation of the only remaining return statement in this
> function.
>
> > @@ -5565,15 +5524,13 @@ void ufshcd_compl_one_cqe(struct ufs_hba
> *hba, int task_tag,
> > ufshcd_release_scsi_cmd(hba, lrbp);
> > /* Do not touch lrbp after scsi done */
> > scsi_done(cmd);
> > - } else if (lrbp->command_type == UTP_CMD_TYPE_DEV_MANAGE ||
> > - lrbp->command_type == UTP_CMD_TYPE_UFS_STORAGE) {
> > - if (hba->dev_cmd.complete) {
> > - if (cqe) {
> > - ocs = le32_to_cpu(cqe->status) & MASK_OCS;
> > - lrbp->utr_descriptor_ptr->header.ocs = ocs;
> > - }
> > - complete(hba->dev_cmd.complete);
> > + } else {
> > + WARN_ON(!hba->dev_cmd.complete);
> > + if (cqe) {
> > + ocs = le32_to_cpu(cqe->status) & MASK_OCS;
> > + lrbp->utr_descriptor_ptr->header.ocs = ocs;
> > }
> > + complete(hba->dev_cmd.complete);
> > }
> > }
>
> The above is a functional change that has not been mentioned in the patch
> description. Please undo the functional change or explain in the patch
> description why this is considered correct.
Will make note of that in the commit log.
Thanks,
Avri
>
> Thanks,
>
> Bart.
