RE: [PATCH 1/2] scsi: ufs: Remove support for old UFSHCI versions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Tue, Mar 26, 2024 at 10:20:13AM -0700, Bart Van Assche wrote:
> > On 3/26/24 01:32, Avri Altman wrote:
> > > @@ -992,10 +976,6 @@ EXPORT_SYMBOL_GPL(ufshcd_is_hba_active);
> > >   u32 ufshcd_get_local_unipro_ver(struct ufs_hba *hba)
> > >   {
> > > -   /* HCI version 1.0 and 1.1 supports UniPro 1.41 */
> > > -   if (hba->ufs_version <= ufshci_version(1, 1))
> > > -           return UFS_UNIPRO_VER_1_41;
> > > -   else
> > >             return UFS_UNIPRO_VER_1_6;
> > >   }
> >
> > Please fix the indentation of the only remaining return statement in
> > this function.
> 
> Even better just remove the function and use UFS_UNIPRO_VER_1_6 directly
> in the two callers.
Done.

Thanks,
Avri





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux