Andrew Vasquez wrote: > On Sat, 01 Sep 2007, FUJITA Tomonori wrote: > >> This adds target mode support to qla2xxx. >> >> With set ql2enable_target_mode module parameter to 1, the driver runs >> in target mode. By default, ql2enable_target_mode is set to 0, and the >> driver should work in initiator mode as before. >> >> The driver could support dual-mode in the future but it doesn't at the >> moment (we need to add dual-mode support tgt first). >> >> It is based on scst qla2xxx target mode driver. Mike converted the >> driver to use tgt long ago. I changed it to use the latest (mainline) >> version of qla2xxx driver and tgt, and also converted it to use fc >> transport class. > > Thanks for doing this. Some initial comments before a full review is > complete, As was seen from the initiator updates needed for 24xx > support, there are comparable changes needed in the area of > target-mode support for 4gb and 8gb parts. Also, which ISPs and > firmwares were exercised with this code? The patch is still under reviewing and will get done, soon. One quick question on the patch, The tgt core will invoke transfer_response() once it completes the command processing. Could you point out where the actual data transfer is happening if the command required it? I guest it should happen in scsi_tgt_kspace_exec(), but not sure where it is happening? Thank you, Seokmann - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html