On Sun, Feb 04, 2024 at 10:19:03AM +0000, Simon Horman wrote: > On Thu, Feb 01, 2024 at 03:34:00PM -0800, Chris Leech wrote: ... > > @@ -264,7 +257,8 @@ static int uio_dmem_genirq_probe(struct platform_device *pdev) > > " dynamic and fixed memory regions.\n"); > > break; > > } > > - uiomem->memtype = UIO_MEM_PHYS; > > + uiomem->memtype = UIO_MEM_DMA_COHERENT; > > + uiomem->dma_device = &pdev->dev, > > Hi Chris, > > a nit from my side. > > Probably the ',' would be better written as a ';' here. > I don't think this is a bug, but using comma like this is > somewhat unexpected and confusing. > > Flagged by clang-17 with -Wcomma That's an embarrassing typo to slip through. I'll fix this,and add the kdoc comments for the API additions. Thanks, - Chris
