On Thu, Feb 01, 2024 at 03:34:00PM -0800, Chris Leech wrote: > Conversion of this driver to use UIO_MEM_DMA_COHERENT for > dma_alloc_coherent memory instead of UIO_MEM_PHYS. > > Signed-off-by: Chris Leech <cleech@xxxxxxxxxx> > --- > drivers/uio/uio_dmem_genirq.c | 22 ++++++++-------------- > 1 file changed, 8 insertions(+), 14 deletions(-) > > diff --git a/drivers/uio/uio_dmem_genirq.c b/drivers/uio/uio_dmem_genirq.c ... > @@ -264,7 +257,8 @@ static int uio_dmem_genirq_probe(struct platform_device *pdev) > " dynamic and fixed memory regions.\n"); > break; > } > - uiomem->memtype = UIO_MEM_PHYS; > + uiomem->memtype = UIO_MEM_DMA_COHERENT; > + uiomem->dma_device = &pdev->dev, Hi Chris, a nit from my side. Probably the ',' would be better written as a ';' here. I don't think this is a bug, but using comma like this is somewhat unexpected and confusing. Flagged by clang-17 with -Wcomma > uiomem->addr = DMEM_MAP_ERROR; > uiomem->size = pdata->dynamic_region_sizes[i]; > ++uiomem; > -- > 2.43.0 > >
