On Sun, 2007-09-09 at 08:56 -0600, Matthew Wilcox wrote: > Rearrange a lot of the functions in the file to get rid of all the > forward > declarations. I get a compile failure at this point in your patch sequence: CC [M] drivers/scsi/advansys.o drivers/scsi/advansys.c:72:2: warning: #warning this driver is still not properly converted to the DMA API drivers/scsi/advansys.c: In function 'AscGetChipBiosAddress': drivers/scsi/advansys.c:11536: error: implicit declaration of function 'AscGetEisaChipCfg' drivers/scsi/advansys.c: At top level: drivers/scsi/advansys.c:11555: error: conflicting types for 'AscGetEisaChipCfg' drivers/scsi/advansys.c:11536: error: previous implicit declaration of 'AscGetEisaChipCfg' was here drivers/scsi/advansys.c: In function 'AscSetIsaDmaSpeed': drivers/scsi/advansys.c:11750: error: implicit declaration of function 'AscGetIsaDmaSpeed' drivers/scsi/advansys.c: At top level: drivers/scsi/advansys.c:11754: error: conflicting types for 'AscGetIsaDmaSpeed' drivers/scsi/advansys.c:11750: error: previous implicit declaration of 'AscGetIsaDmaSpeed' was here make[2]: *** [drivers/scsi/advansys.o] Error 1 make[1]: *** [drivers/scsi] Error 2 make: *** [drivers] Error 2 I've put 1-15 in .. could you rebase against scsi-misc and eliminate this problem? Thanks, James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html