On Tue, Oct 17, 2023 at 10:14:19AM +0200, Hannes Reinecke wrote: >> What is the point of passing in the host_byte vs just setting it in >> the caller? >> > Hmm. Sure, could do. > >> In fat I'm not even quite sure what the point of the existing helper >> is, as moving the command to the passed in queue doesn't provide >> much of a useful abstraction. >> > Share your sentiments. > One could open-code it, but if I move the host_byte setting into the > caller this function won't be touched at all. Yes, I can rant about existing code, not just new code :) > And it's time to clean up the entire list splice-and-dice game in > SCSI EH once this rework is in; my plan is to move failed commands > onto a per-entity list, and merge them onto the next higher entity > list once an escalation fails. > > So maybe shelf it for now, and just open-code the host_byte setting > in the caller. Sounds good.
