On Mon, Oct 16, 2023 at 02:15:38PM +0200, Hannes Reinecke wrote:
> When SCSI EH completes we should be setting the host byte to
> DID_ABORT, DID_RESET, or DID_TRANSPORT_DISRUPTED to inform
> the caller that some EH processing has happened.
I have a hard time following this commit log. Yes, we probably
should. But so far we haven't, so why is this suddenly a problem?
> -void scsi_eh_finish_cmd(struct scsi_cmnd *scmd, struct list_head *done_q)
> +void __scsi_eh_finish_cmd(struct scsi_cmnd *scmd, struct list_head *done_q,
> + int host_byte)
> {
> + if (host_byte)
> + set_host_byte(scmd, host_byte);
> list_move_tail(&scmd->eh_entry, done_q);
What is the point of passing in the host_byte vs just setting it in
the caller?
In fat I'm not even quite sure what the point of the existing helper
is, as moving the command to the passed in queue doesn't provide
much of a useful abstraction.
