On 10/16/23 15:59, Johannes Thumshirn wrote:
On 16.10.23 14:16, Hannes Reinecke wrote:-void scsi_eh_finish_cmd(struct scsi_cmnd *scmd, struct list_head *done_q) +void __scsi_eh_finish_cmd(struct scsi_cmnd *scmd, struct list_head *done_q, + int host_byte) { + if (host_byte) + set_host_byte(scmd, host_byte);I think the 'if' is not needed here.
Actually, I prefer to keep it as passing in 'DID_OK' would _not_ modify the status; leaving out the 'if' would always overwrite it. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@xxxxxxx +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman
