On Wed, Sep 13, 2023 at 04:59:31PM +0800, Yi Zhang wrote: > The issue still can be reproduced on the latest linux tree[2]. > To reproduce I need to run about 1000 times blktests block/001, and > bisect shows it was introduced with commit[1], as it was not 100% > reproduced, not sure if it's the culprit? > > > [1] 9257959a6e5b locking/atomic: scripts: restructure fallback ifdeffery > [2] > [ 2304.536339] scsi 48:0:0:0: CD-ROM Linux scsi_debug > 0191 PQ: 0 ANSI: 7 > [ 2304.540805] sr 50:0:0:0: Attached scsi CD-ROM sr3 > [ 2304.544574] scsi 48:0:0:0: Power-on or device reset occurred > [ 2304.600645] sr 48:0:0:0: [sr1] scsi-1 drive > [ 2304.616364] scsi 51:0:0:0: CD-ROM Linux scsi_debug > 0191 PQ: 0 ANSI: 7 > [ 2304.624639] scsi 51:0:0:0: Power-on or device reset occurred > [ 2304.626634] sr 48:0:0:0: Attached scsi CD-ROM sr1 > [ 2304.680537] sr 51:0:0:0: [sr2] scsi-1 drive > [ 2304.706394] sr 51:0:0:0: Attached scsi CD-ROM sr2 > [ 2304.746329] scsi 49:0:0:0: CD-ROM Linux scsi_debug > 0191 PQ: 0 ANSI: 7 > [ 2304.754569] scsi 49:0:0:0: Power-on or device reset occurred > [ 2304.756302] scsi 50:0:0:0: CD-ROM Linux scsi_debug > 0191 PQ: 0 ANSI: 7 > [ 2304.768483] scsi 50:0:0:0: Power-on or device reset occurred > [ 2304.806321] scsi 48:0:0:0: CD-ROM Linux scsi_debug > 0191 PQ: 0 ANSI: 7 > [ 2304.810587] sr 49:0:0:0: [sr0] scsi-1 drive > [ 2304.814561] scsi 48:0:0:0: Power-on or device reset occurred > [ 2304.824475] sr 50:0:0:0: [sr3] scsi-1 drive > [ 2304.836384] scsi 51:0:0:0: CD-ROM Linux scsi_debug > 0191 PQ: 0 ANSI: 7 > [ 2304.840364] sr 49:0:0:0: Attached scsi CD-ROM sr0 > [ 2304.844619] scsi 51:0:0:0: Power-on or device reset occurred > [ 2304.850444] sr 50:0:0:0: Attached scsi CD-ROM sr3 > [ 2304.874563] sr 48:0:0:0: [sr1] scsi-1 drive > [ 2304.900660] sr 51:0:0:0: [sr2] scsi-1 drive > [ 2304.901506] sr 48:0:0:0: Attached scsi CD-ROM sr1 > [ 2304.926306] sr 51:0:0:0: Attached scsi CD-ROM sr2 > [ 2305.056432] scsi 50:0:0:0: CD-ROM Linux scsi_debug > 0191 PQ: 0 ANSI: 7 > [ 2305.056572] scsi 49:0:0:0: CD-ROM Linux scsi_debug > 0191 PQ: 0 ANSI: 7 > [ 2305.064635] scsi 50:0:0:0: Power-on or device reset occurred > [ 2305.072821] scsi 49:0:0:0: Power-on or device reset occurred > [ 2305.086286] scsi 51:0:0:0: CD-ROM Linux scsi_debug > 0191 PQ: 0 ANSI: 7 > [ 2305.086357] scsi 48:0:0:0: CD-ROM Linux scsi_debug > 0191 PQ: 0 ANSI: 7 > [ 2305.094521] scsi 51:0:0:0: Power-on or device reset occurred > [ 2305.102693] scsi 48:0:0:0: Power-on or device reset occurred > [ 2305.128785] sr 50:0:0:0: [sr0] scsi-1 drive > [ 2305.134445] sr 49:0:0:0: [sr1] scsi-1 drive > [ 2305.154728] sr 50:0:0:0: Attached scsi CD-ROM sr0 > [ 2305.158607] sr 51:0:0:0: [sr2] scsi-1 drive > [ 2305.160392] sr 49:0:0:0: Attached scsi CD-ROM sr1 > [ 2305.164254] sr 48:0:0:0: [sr3] scsi-1 drive > [ 2305.184185] sr 51:0:0:0: Attached scsi CD-ROM sr2 > [ 2305.190086] sr 48:0:0:0: Attached scsi CD-ROM sr3 > [ 2305.555658] Unable to handle kernel execute from non-executable > memory at virtual address ffffc61b656052e8 > [ 2305.565301] Mem abort info: > [ 2305.568086] ESR = 0x000000008600000e > [ 2305.571822] EC = 0x21: IABT (current EL), IL = 32 bits > [ 2305.577123] SET = 0, FnV = 0 > [ 2305.580164] EA = 0, S1PTW = 0 > [ 2305.583292] FSC = 0x0e: level 2 permission fault > [ 2305.588074] swapper pgtable: 4k pages, 48-bit VAs, pgdp=0000080731fa0000 > [ 2305.594761] [ffffc61b656052e8] pgd=1000080ffffff003, > p4d=1000080ffffff003, pud=1000080fffffe003, pmd=0068080732e00f01 > [ 2305.605362] Internal error: Oops: 000000008600000e [#1] SMP > [ 2305.610922] Modules linked in: scsi_debug sr_mod pktcdvd cdrom > rfkill sunrpc vfat fat acpi_ipmi arm_spe_pmu ipmi_ssif ipmi_devintf > ipmi_msghandler arm_cmn arm_dmc620_pmu arm_dsu_pmu cppc_cpufreq loop > fuse zram xfs crct10dif_ce ghash_ce nvme sha2_ce nvme_core > sha256_arm64 igb sha1_ce ast sbsa_gwdt nvme_common > i2c_designware_platform i2c_algo_bit i2c_designware_core xgene_hwmon > dm_mod [last unloaded: scsi_debug] > [ 2305.647236] CPU: 85 PID: 1 Comm: systemd Kdump: loaded Not tainted > 6.6.0-rc1+ #13 > [ 2305.654706] Hardware name: GIGABYTE R152-P31-00/MP32-AR1-00, BIOS > F31n (SCP: 2.10.20220810) 09/30/2022 > [ 2305.663997] pstate: 20400009 (nzCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > [ 2305.670946] pc : in_lookup_hashtable+0x1138/0x2000 > [ 2305.675728] lr : rcu_do_batch+0x194/0x488 > [ 2305.679727] sp : ffff8000802abe60 > [ 2305.683029] x29: ffff8000802abe60 x28: ffffc61b6524c7c0 x27: ffffc61b63452f40 > [ 2305.690152] x26: ffff080f37ab6438 x25: 000000000000000a x24: 0000000000000000 > [ 2305.697274] x23: 0000000000000002 x22: ffff8000802abec0 x21: ffff080f37ab63c0 > [ 2305.704396] x20: ffff07ff8136a580 x19: 0000000000000003 x18: 0000000000000000 > [ 2305.711519] x17: ffff41f3d3161000 x16: ffff8000802a8000 x15: 0000000000000000 > [ 2305.718641] x14: 0000000000000000 x13: ffff07ffa131802d x12: ffff80008041bb94 > [ 2305.725764] x11: 0000000000000040 x10: ffff07ff802622e8 x9 : ffffc61b63452e30 > [ 2305.732887] x8 : 000002189dce1780 x7 : ffff07ff8d5c1000 x6 : ffff41f3d3161000 > [ 2305.740009] x5 : ffff07ff8136a580 x4 : ffff080f37aba960 x3 : 000000001550a055 > [ 2305.747131] x2 : 0000000000000000 x1 : ffffc61b656052e8 x0 : ffff080184c565f0 > [ 2305.754254] Call trace: > [ 2305.756687] in_lookup_hashtable+0x1138/0x2000 > [ 2305.761119] rcu_core+0x268/0x350 > [ 2305.764422] rcu_core_si+0x18/0x30 > [ 2305.767812] __do_softirq+0x120/0x3d4 > [ 2305.771462] ____do_softirq+0x18/0x30 > [ 2305.775112] call_on_irq_stack+0x24/0x30 > [ 2305.779022] do_softirq_own_stack+0x24/0x38 > [ 2305.783192] __irq_exit_rcu+0xfc/0x130 > [ 2305.786929] irq_exit_rcu+0x18/0x30 > [ 2305.790404] el1_interrupt+0x4c/0xe8 > [ 2305.793969] el1h_64_irq_handler+0x18/0x28 > [ 2305.798052] el1h_64_irq+0x78/0x80 > [ 2305.801441] d_same_name+0x50/0xd0 > [ 2305.804832] __lookup_slow+0x64/0x158 > [ 2305.808482] walk_component+0xe0/0x1a0 > [ 2305.812219] path_lookupat+0x7c/0x1b8 > [ 2305.815869] filename_lookup+0xb4/0x1b8 > [ 2305.819692] vfs_statx+0x94/0x1a8 > [ 2305.822995] vfs_fstatat+0xd4/0x110 > [ 2305.826471] __do_sys_newfstatat+0x58/0xa8 > [ 2305.830556] __arm64_sys_newfstatat+0x28/0x40 > [ 2305.834901] invoke_syscall.constprop.0+0x80/0xd8 > [ 2305.839592] do_el0_svc+0x48/0xd0 > [ 2305.842894] el0_svc+0x4c/0x1c0 > [ 2305.846023] el0t_64_sync_handler+0x120/0x130 > [ 2305.850367] el0t_64_sync+0x1a4/0x1a8 > [ 2305.854017] Code: 00000000 00000000 00000000 00000000 (84c565f1) > [ 2305.860098] SMP: stopping secondary CPUs > [ 2305.865048] Starting crashdump kernel... > [ 2305.868958] Bye! > > Please don't top-post; reply inline with appropriate context instead. Anyway, thanks for bisecting this regression. I'm adding it to regzbot: #regzbot ^introduced: 9257959a6e5b4f #regzbot title: restructuring atomic locking conditionals causes vfs dentry lock protection failure -- An old man doll... just what I always wanted! - Clara
Attachment:
signature.asc
Description: PGP signature