[PATCH v2 0/8] libata: remove references to 'old' error handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Niklas Cassel <niklas.cassel@xxxxxxx>

Hi all,

now that the ipr driver has been modified to not hook into libata
all drivers now use the 'new' error handler, so we can remove any
references to it. And do a general cleanup to remove callbacks
which are no longer needed.


Changes since v1:
-Rebased against Damien's libata for-next branch. (Fixed conflicts in
 ata_qc_complete().)
-Fixed comments from Damien.
-Fixed comments from myself.
-Do not dump all QCs unconditionally (which should make the performance
 regression reported by the test robot go away.)
-Since ata_dump_status() was only called for drivers without .error_handler
 callback, this function is now unused and unreachable, so it was removed.
-Since atapi_qc_complete() can no longer reach the "old EH" failure paths
 (code will now always take the top branch on error), they are removed.
-Since atapi_eh_request_sense() can no longer be called, it is now removed.
 (The atapi_eh_request_sense() version called by EH is still there.)
-Patch 7/8 and 8/8 are new in V2.


Hannes Reinecke (6):
  ata: remove reference to non-existing error_handler()
  ata,scsi: remove ata_sas_port_{start,stop} callbacks
  ata,scsi: remove ata_sas_port_destroy()
  ata: remove ata_sas_sync_probe()
  ata: inline ata_port_probe()
  ata,scsi: cleanup ata_port_probe()

Niklas Cassel (2):
  ata: sata_sx4: drop already completed TODO
  ata: remove ata_bus_probe()

 drivers/ata/libata-core.c          | 355 +++++++----------------------
 drivers/ata/libata-eh.c            | 150 +++++-------
 drivers/ata/libata-sata.c          |  77 -------
 drivers/ata/libata-scsi.c          | 142 +-----------
 drivers/ata/libata-sff.c           |  30 +--
 drivers/ata/libata.h               |   3 -
 drivers/ata/sata_sx4.c             |   1 -
 drivers/scsi/libsas/sas_ata.c      |   6 +-
 drivers/scsi/libsas/sas_discover.c |   2 +-
 include/linux/libata.h             |   6 +-
 10 files changed, 170 insertions(+), 602 deletions(-)

-- 
2.41.0




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux