On Wed, Jul 19, 2023 at 07:45:48AM +0000, 杜敏杰 wrote: > session might contain private part of the password, so better use > kfree_sensitive() to free it. > In iscsi_session_free() use kfree_sensitive() to free session->password, > session->password_in, session->username, session->username_in. > > Signed-off-by: Minjie Du <duminjie@xxxxxxxx> This looks good, thank you for the follow up to Mike's review. Reviewed-by: Chris Leech <cleech@xxxxxxxxxx> > --- > drivers/scsi/libiscsi.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c > index 0fda8905e..a307da898 100644 > --- a/drivers/scsi/libiscsi.c > +++ b/drivers/scsi/libiscsi.c > @@ -3132,10 +3132,10 @@ void iscsi_session_free(struct iscsi_cls_session *cls_session) > struct module *owner = cls_session->transport->owner; > > iscsi_pool_free(&session->cmdpool); > - kfree(session->password); > - kfree(session->password_in); > - kfree(session->username); > - kfree(session->username_in); > + kfree_sensitive(session->password); > + kfree_sensitive(session->password_in); > + kfree_sensitive(session->username); > + kfree_sensitive(session->username_in); > kfree(session->targetname); > kfree(session->targetalias); > kfree(session->initiatorname); > -- > 2.39.0 >
