On 18/07/2023 16:31, Mike Christie wrote:
Hi Mike,
+
if (err == SCSI_DH_OK) {
As I see, err is initially set to SCSI_DH_OK when declared. Then if we need to retry and 2nd call to scsi_execute_cmd() passes, such that rc == 0, then err still holds the old value. This seems same as pre-existing behaviour - is this proper?
I guess this has been working by accident.
When that happens we end up returning one of the retryable error codes
to dm-multipath. It will then recall us, and before we re-run this
function we will run check_ownership and see that the last call worked.
I'd suggest that we fix this up as a prep patch, if you don't mind.
Thanks,
John
