On 7/17/23 11:29, Mike Christie wrote:
On 7/17/23 12:05 PM, Bart Van Assche wrote:The original code only retries if ->result > 0. Is my understanding correct that the new code retries SCSI command execution whether ->result is < 0 or > 0? If so, I think this patch introduces an unintended behavior change.The new code does not retry when result is < 0. SCMD_FAILURE_RESULT_ANY is for cases where result > 0.
Right. Hence: Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>
