On 5/6/23 15:48, Martin K. Petersen wrote:
Although, I'd also love to see pre-decoded ASC and ASCQ codes in the
scsi_cmnd at some point.
Yep! It would be nice to have these readily available.
Implementing this seems nontrivial and risky to me. As an example,
whether or not scsi_decide_disposition() calls scsi_check_sense()
depends on the command result. Guaranteeing that
scsi_command_normalize_sense() is called independent of the command
result implies moving this call from scsi_check_sense() to somewhere
else, e.g. scsi_decide_disposition(). Unfortunately scsi_check_sense()
is not only called from the SCSI completion path but also by ATA code
that is not related to the SCSI completion path (ata_eh_analyze_tf()).
So I consider this change as out-of-scope for this patch series.
Bart.
