Re: [PATCH v2 3/5] scsi: core: Trace SCSI sense data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Bart Van Assche <bvanassche@xxxxxxx>
Subject: Re: [PATCH v2 3/5] scsi: core: Trace SCSI sense data
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 5 May 2023 08:01:45 +0200
Cc: "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>, Jaegeuk Kim <jaegeuk@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, Niklas Cassel <niklas.cassel@xxxxxxx>, Ming Lei <ming.lei@xxxxxxxxxx>, Hannes Reinecke <hare@xxxxxxx>, John Garry <john.g.garry@xxxxxxxxxx>, Mike Christie <michael.christie@xxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Changyuan Lyu <changyuanl@xxxxxxxxxx>, Jolly Shah <jollys@xxxxxxxxxx>, Vishakha Channapattan <vishakhavc@xxxxxxxxxx>
In-reply-to: <20230503230654.2441121-4-bvanassche@acm.org>
User-agent: Mutt/1.5.17 (2007-11-01)

On Wed, May 03, 2023 at 04:06:52PM -0700, Bart Van Assche wrote:
> If a command fails, SCSI sense data is essential to determine why it
> failed. Hence make the sense key, ASC and ASCQ codes available in the
> ftrace output.

Looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Although, I'd also love to see pre-decoded ASC and ASCQ codes in the
scsi_cmnd at some point.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Follow-Ups:
- Re: [PATCH v2 3/5] scsi: core: Trace SCSI sense data
  - From: Martin K. Petersen

References:
- [PATCH v2 0/5] SCSI core patches
  - From: Bart Van Assche
- [PATCH v2 3/5] scsi: core: Trace SCSI sense data
  - From: Bart Van Assche

Prev by Date: Re: [PATCH v2 2/5] scsi: core: Update a source code comment
Next by Date: Re: [PATCH] scsi:dc395x: Correct "structures" spelling mistakes
Previous by thread: Re: [PATCH v2 3/5] scsi: core: Trace SCSI sense data
Next by thread: Re: [PATCH v2 3/5] scsi: core: Trace SCSI sense data
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]