On Wed, 2023-04-19 at 12:24 -0700, Bart Van Assche wrote: > On 4/19/23 11:33, James Bottomley wrote: > > So if we can't reliably get it right, let's not do it at all. The > > previous argument you made was about problems with I/O to shutdown > > PCI devices. That's not SCSI specific, so either we fix it for > > everything or decide it's not really a problem for anything. > > The reference to PCI devices was an example only. As mentioned > elsewhere in this email thread, sd_shutdown() does not do what it > should do, namely to quiesce I/O. From include/linux/bus.h: > > * @shutdown: Called at shut-down time to quiesce the device. Shutdown seems to be one of the most ill documented device hooks. I really don't think we should be declaring existing code to be buggy based on this single comment. But the fact remains that if you want to act on it, block is the correct place to shut down the queues. James
