Re: [PATCH 5/6] aha152x.c - Fix check_condition code-path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 01 Aug 2007 08:51:14 -0500 James Bottomley wrote:

> On Tue, 2007-07-31 at 11:40 -0700, Randy Dunlap wrote:
> > On Tue, 31 Jul 2007 10:59:51 +0300 Boaz Harrosh wrote:
> > 
> > > Randy Dunlap wrote:
> > > > 
> > > > Since you grok all of that (above), maybe you can help here:
> > > > 
> > > > With these 6 patches applied, I do the following:
> > > > 
> > > > 1.  insert PCMCIA aha152x card with SCSI drive attached (/dev/sdb4)
> > > > 2.  mount -t vfat /dev/sdb4 /mnt/disk
> > > > 3.  play with /mnt/disk
> > > > 4.  umount /mnt/disk
> > > > 
> > > > Now I would like to rmmod the aha152x_cs module, but its use count
> > > > is 2.  Even if I eject the card, its use count stays at 2.
> > > > Maybe the reset or check_condition patch doesn't clean up correctly,
> > > > or one of them isn't releasing a used resource ?
> > > > 
> > > > (this is 2.6.23-rc1 + your 6 patches + 1 acpi seq-file throttling fix.)
> > > > 
> > > 
> > > I had an hard look and a very careful line-by-line compare
> > > and I can't find anything obvious. Could you do a bisect.
> > > maybe it will give me a clue as to where to look. Also please
> > > Enable debug prints. Maybe the driver is stuck at some state 
> > > and does not exit.
> > 
> > The good news is that this problem has nothing to do with this
> > patch series.  The bad news is that this problem is there anyway.
> 
> So on a functionality basis you're prepared to ack this patch set on the
> basis of empirical testing on the grounds that the bug predates them?

Yes.  Acked-and-tested-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>

Thanks.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux