Hi Bart, I love your patch! Yet something to improve: [auto build test ERROR on mkp-scsi/for-next] [also build test ERROR on jejb-scsi/for-next linus/master v6.2-rc6] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Bart-Van-Assche/scsi-core-Introduce-the-BLIST_BROKEN_FUA-flag/20230202-021019 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next patch link: https://lore.kernel.org/r/20230201180637.2102556-3-bvanassche%40acm.org patch subject: [PATCH 2/2] scsi: ufs: Use SYNCHRONIZE CACHE instead of FUA config: x86_64-randconfig-a012-20230130 (https://download.01.org/0day-ci/archive/20230202/202302021626.GfHCwXIh-lkp@xxxxxxxxx/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/4edde0173805f04faa8e79aab4de3e929ea4b7c0 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Bart-Van-Assche/scsi-core-Introduce-the-BLIST_BROKEN_FUA-flag/20230202-021019 git checkout 4edde0173805f04faa8e79aab4de3e929ea4b7c0 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): >> drivers/ufs/core/ufshcd.c:5060:22: error: use of undeclared identifier 'BLIST_BROKEN_FUA' sdev->sdev_bflags = BLIST_BROKEN_FUA; ^ drivers/ufs/core/ufshcd.c:9988:44: warning: shift count >= width of type [-Wshift-count-overflow] if (!dma_set_mask_and_coherent(hba->dev, DMA_BIT_MASK(64))) ^~~~~~~~~~~~~~~~ include/linux/dma-mapping.h:76:54: note: expanded from macro 'DMA_BIT_MASK' #define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1)) ^ ~~~ 1 warning and 1 error generated. vim +/BLIST_BROKEN_FUA +5060 drivers/ufs/core/ufshcd.c 5031 5032 /** 5033 * ufshcd_slave_alloc - handle initial SCSI device configurations 5034 * @sdev: pointer to SCSI device 5035 * 5036 * Returns success 5037 */ 5038 static int ufshcd_slave_alloc(struct scsi_device *sdev) 5039 { 5040 struct ufs_hba *hba; 5041 5042 hba = shost_priv(sdev->host); 5043 5044 /* Mode sense(6) is not supported by UFS, so use Mode sense(10) */ 5045 sdev->use_10_for_ms = 1; 5046 5047 /* DBD field should be set to 1 in mode sense(10) */ 5048 sdev->set_dbd_for_ms = 1; 5049 5050 /* allow SCSI layer to restart the device in case of errors */ 5051 sdev->allow_restart = 1; 5052 5053 /* REPORT SUPPORTED OPERATION CODES is not supported */ 5054 sdev->no_report_opcodes = 1; 5055 5056 /* WRITE_SAME command is not supported */ 5057 sdev->no_write_same = 1; 5058 5059 /* Use SYNCHRONIZE CACHE instead of FUA to improve performance */ > 5060 sdev->sdev_bflags = BLIST_BROKEN_FUA; 5061 5062 ufshcd_lu_init(hba, sdev); 5063 5064 ufshcd_setup_links(hba, sdev); 5065 5066 return 0; 5067 } 5068 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
