Re: [PATCH 23/24] advansys: Improve interrupt handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



OK, I think I misunderstood your explanation. Rather than judging based on English emails, I went back and looked at the old and new code.

Looking at the old code, there is a clear 1-to-1-to-1-to-1 correspondence between adapter, request_irq() call, scsi_host, and boardp. So what the old code is doing during probe is quite normal.

I thought you were saying there were multiple request_irq() calls for a single adapter.

The only thing that's abnormal is the interrupt handler checking multiple boards for events, which you rightly removed.

There is absolutely no need to add IRQF_SHARED to non-PCI devices or anything like that.

At this point, looking at your new code, I would only add
	"replace spin_lock_irqsave with spin_lock in interrupt handler"
and
	"delete no-ops DvcEnterCritical and DvcLeaveCritical"
to the todo list.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux