Re: [PATCH 23/24] advansys: Improve interrupt handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Matthew Wilcox wrote:
On Fri, Jul 27, 2007 at 10:49:17AM -0400, Jeff Garzik wrote:
Matthew Wilcox wrote:
Pass the Scsi_Host to the interrupt handler, rather than polling all
hosts for each interrupt.
Return IRQ_NONE if we didn't handle this interrupt
Don't set the IRQF_DISABLED flag; this is not a fast-executing interrupt
handler.

Signed-off-by: Matthew Wilcox <matthew@xxxxxx>
hrm.

I thought you had multiple scsi hosts per board? Thus multiple scsi hosts per interrupt?

Right.  We'll request the interrupt twice, each time with a different
scsi_host.

ewwwwww.  That's, um, broken :)

I presume request_irq() will fail on non-ISA for subsequent calls, and your interrupt handler gets called -twice- for every single interrupt.




-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux