Re: [PATCH 7/24] advansys: Convert to EISA driver model

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Also, general comment:

To be, or not to be:  CONFIG_PCI and CONFIG_EISA

Even with !CONFIG_FOO handling in the relevant header file, you still wind up with dead code being built into the driver. The !CONFIG_FOO behavior remains correct (a no-op), of course.

I don't have an opinion either way. On one hand, the present setup is clean. On the other hand, you are likely to run into non-ISA platforms that might not be happy with building non-PCI code. It's not the eisa_register_driver() that is the problem, but other ISA-specific functions you wind up using in the process.

Plus, Andi likes to make a big fuss about building ISA code on x86-64 :)

	Jeff





-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux