On Fri, Jul 27, 2007 at 10:17:39AM -0400, Jeff Garzik wrote:
> >+static __devexit int advansys_eisa_remove(struct device *dev)
> >+{
> >+ int i, ioport;
> >+ struct eisa_scsi_data *data = dev_get_drvdata(dev);
> >+
> >+ for (i = 0; i < 2; i++) {
> >+ struct Scsi_Host *shost = data->host[i];
> >+ if (!shost)
> >+ continue;
> >+ ioport = shost->io_port;
> >+ advansys_remove(data->host[i]);
>
> what is the point of assigning ioport a never-used value?
It gets used in the next patch:
ioport = shost->io_port;
advansys_release(data->host[i]);
release_region(ioport, ASC_IOADR_GAP);
I can move that one line between patches (and clearly, I should use 'shost'
instead of 'data->host[i]'). Guess I missed it when shuffling patches
--
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
