On 2022/12/14 21:16, John Garry wrote:
On 14/12/2022 12:47, Jason Yan wrote:
Note: you made the changes as I suggested, so I think that you could
have picked up my RB tag from v2 series, thanks.
Yeah I used to do that before. But last time Damien educated me that I
must drop all the RB tags after the patch is changed so I didn't take
it.
I think that they should be dropped if significant changes are made
since the original tag was granted - that's for sure.
Yes, definitely.
However if I supply a RB tag but also suggest a smallish change along
with it and you implement that change in a new version, then it's ok to
pick up the tag.
Thanks for the explanation. I'm not sure if Damien agree with that.
At a brief glance, I could not see this policy mentioned in
submitting-patches.rst .
Thanks!
.
