On 2022/12/14 18:05, John Garry wrote:
On 14/12/2022 07:06, Jason Yan wrote:
Factor out sas_ata_add_dev() and put it in sas_ata.c since it is a sata
related interface. Also follow the standard coding style to define an
inline empty function when CONFIG_SCSI_SAS_ATA is not enabled.
Cc: John Garry<john.g.garry@xxxxxxxxxx>
Signed-off-by: Jason Yan<yanaijie@xxxxxxxxxx>
Reviewed-by: John Garry <john.g.garry@xxxxxxxxxx>
Thanks John.
Note: you made the changes as I suggested, so I think that you could
have picked up my RB tag from v2 series, thanks.
Yeah I used to do that before. But last time Damien educated me that I
must drop all the RB tags after the patch is changed so I didn't take
it.
May I should remember reviewer's personal preference ^-^
Thanks
Jason
.
