Re: 52a518019c causes issue with Qualcomm UFSHC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 24 2022 at 21:36 -0800, Manivannan Sadhasivam wrote:
On Mon, Nov 21, 2022 at 02:56:34PM -0800, Asutosh Das wrote:
On Sat, Nov 19 2022 at 20:16 -0800, Powen Kao (高伯文) wrote:
> Hi Asutosh,
>
>
>
> Reverting the patch doesn't sound feasible on MTK platform ☹
>
>
>
> > > I don't think invoking a clock scaling notification during
>
> > > ufshcd_host_reset_and_restore() sounds right to me.
>
> But the point is that driver has the right to know that the clk is scaled no matter where ufshcd_scale_clks() is invoked, no?
>
>
>
> Do you mind applying this patch on qcom driver to check on host status before further operation?

+ Mani, linux-scsi

Hello Powen
Thanks for the change. I will think of something to work-around the issue.
However, I would like to point out that a change that breaks an existing driver
must be fixed or reverted, not the other way around.


May I know what the actual issue is? I've tested v6.1-rc1 that has this change
and didn't see any issues on SM8250, SDM845 and SM8450.

Thanks,
mani

Set rpm-lvl=5, enable scaling and let it enter runtime-suspend and then resume.
You should see the CMD17 timeout.

-asd


--
மணிவண்ணன் சதாசிவம்



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux