On Mon, Nov 21, 2022 at 02:56:34PM -0800, Asutosh Das wrote: > On Sat, Nov 19 2022 at 20:16 -0800, Powen Kao (高伯文) wrote: > > Hi Asutosh, > > > > > > > > Reverting the patch doesn't sound feasible on MTK platform ☹ > > > > > > > > > > I don't think invoking a clock scaling notification during > > > > > > ufshcd_host_reset_and_restore() sounds right to me. > > > > But the point is that driver has the right to know that the clk is scaled no matter where ufshcd_scale_clks() is invoked, no? > > > > > > > > Do you mind applying this patch on qcom driver to check on host status before further operation? > > + Mani, linux-scsi > > Hello Powen > Thanks for the change. I will think of something to work-around the issue. > However, I would like to point out that a change that breaks an existing driver > must be fixed or reverted, not the other way around. > May I know what the actual issue is? I've tested v6.1-rc1 that has this change and didn't see any issues on SM8250, SDM845 and SM8450. Thanks, mani > -asd > -- மணிவண்ணன் சதாசிவம்
