On Fri, Nov 04, 2022 at 06:18:54PM -0500, Mike Christie wrote: > + if (!scmd->result || !scmd->failures) > + return SCSI_RETURN_NOT_HANDLED; I'd probably move the ->result check into the caller to make it clear thi code is a no-op for successful execution. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>