Re: [PATCH v6 02/35] scsi: Allow passthrough to override what errors to retry

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/8/22 5:57 PM, Bart Van Assche wrote:
> On 11/4/22 16:18, Mike Christie wrote:
>> +/**
>> + * scsi_check_passthrough - Determine if passthrough scsi_cmnd needs a retry.
>> + * @scmd: scsi_cmnd to check.
>> + *
>> + * Return value:
>> + *    SCSI_RETURN_NOT_HANDLED - if the caller should process the command
> 
> Should "process the command" perhaps be changed into "examine the command status" since SCSI devices process SCSI commands while scsi_check_passthrough() callers examine the command status? Otherwise this patch looks good to me. Hence:
> 
> Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>

I like your suggestion and will change it.




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux