On Sun, Oct 30, 2022 at 01:06:20AM +0300, Dmitry Baryshkov wrote: > On 29/10/2022 17:16, Manivannan Sadhasivam wrote: > > Fix the register name used for offset 0xD0. The correct name is > > REG_UFS_PARAM0. > > The vendor kernels starting from 3.10 define this register as > RETRY_TIMER_REG (but it is unused). I'd suggest adding a comment about the > older register name. > Makes sense to me. Thanks, Mani > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > --- > > drivers/ufs/host/ufs-qcom.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/ufs/host/ufs-qcom.h b/drivers/ufs/host/ufs-qcom.h > > index 6cb0776456b3..214ea50acab9 100644 > > --- a/drivers/ufs/host/ufs-qcom.h > > +++ b/drivers/ufs/host/ufs-qcom.h > > @@ -33,7 +33,7 @@ enum { > > REG_UFS_TX_SYMBOL_CLK_NS_US = 0xC4, > > REG_UFS_LOCAL_PORT_ID_REG = 0xC8, > > REG_UFS_PA_ERR_CODE = 0xCC, > > - REG_UFS_RETRY_TIMER_REG = 0xD0, > > + REG_UFS_PARAM0 = 0xD0, > > REG_UFS_PA_LINK_STARTUP_TIMER = 0xD8, > > REG_UFS_CFG1 = 0xDC, > > REG_UFS_CFG2 = 0xE0, > > -- > With best wishes > Dmitry > -- மணிவண்ணன் சதாசிவம்