On Wed, 2022-10-19 at 14:06 -0700, Bart Van Assche wrote: > On 10/19/22 12:50, Asutosh Das wrote: > > While adding the vops it occurred to me that it'd remain empty > > because > > ufs-qcom > > doesn't need it. And I'm not sure how MTK register space is laid > > out. > > So please can you help add a vops in the next version? > > I can address the other comment and push the series. > > Please do not introduce new vops without adding at least one > implementation of the vop in the same patch series. How about > letting > MediaTek add more vops as necessary in a separate patch series and > focusing in this patch series on UFSHCI 4.0 compliance? > I am not sure whether other SoC vendor's register definition follow this patch's arrangement or not. As I explain Mediatek treat UFS as a single IP and map whole UFS register address space one time. To speed up landing this series, please bypass this vops. I will send a separate patch to add this vops Eddie
