Re: [PATCH v4 36/36] scsi: Add kunit tests for scsi_check_passthrough

[Bart Van Assche <bvanassche@xxxxxxx>]

On 10/16/22 12:59, Mike Christie wrote:
> +config SCSI_KUNIT_TEST
> +	bool "KUnit tests for SCSI Mid Layer" if !KUNIT_ALL_TESTS
> +	depends on SCSI && KUNIT
> +        default KUNIT_ALL_TESTS

Is it on purpose that spaces are used to indent the above line instead 
of a tab?

> +	help
> +	  Run SCSI Mid Layer's KUnit tests.
> +

[ ... ]

> diff --git a/drivers/scsi/scsi_test_error.c b/drivers/scsi/scsi_test_error.c

Isn't the convention to use the "_test.c" suffix for unit tests 
(scsi_test_error.c -> scsi_error_test.c)?

> + * KUnit tests for the scsi_error.c.

Should "the" perhaps be left out from the above line?

Otherwise this patch looks good to me.

Thanks,

Bart.