Re: [PATCH v3 8/8] scsi: ufs: Fix a deadlock between PM and the SCSI error handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/2/22 23:18, Adrian Hunter wrote:
This is OK for now, but ufshcd_link_recovery() doesn't check for errors
*after* reset, and retry error handling - in which case it might need also
the error handling that ufshcd_err_handler() does.

It might be better to have only 1 error handling function.

Hi Adrian,

I'm fine with sharing code between error handling contexts but I'm not sure a single error handling function is the best solution. Having a single error handling function and calling it from the timeout function would require to add so many if-tests into ufshcd_err_handler() that it would make that function unreadable.

Thanks,

Bart.




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux