On 9/22/22 18:05, Asutosh Das wrote:
+/* Resources */
+static const struct ufshcd_res_info_t ufshcd_res_info[RES_MAX] = {
+ {.name = "ufs_mem", .resource = NULL, .base = NULL},
+ {.name = "mcq", .resource = NULL, .base = NULL},
+ /* Submission Queue DAO */
+ {.name = "mcq_sqd", .resource = NULL, .base = NULL},
+ /* Submission Queue Interrupt Status */
+ {.name = "mcq_sqis", .resource = NULL, .base = NULL},
+ /* Completion Queue DAO */
+ {.name = "mcq_cqd", .resource = NULL, .base = NULL},
+ /* Completion Queue Interrupt Status */
+ {.name = "mcq_cqis", .resource = NULL, .base = NULL},
+ /* MCQ vendor specific */
+ {.name = "mcq_vs", .resource = NULL, .base = NULL},
+};
Please leave out the members that are NULL (.resource and .base) since
the compiler will initialize these for you.
/**
+ * struct ufshcd_res_info_t - MCQ related resource regions
+ *
+ * @name: resource name
+ * @resource: pointer to resource region
+ * @base: register base address
+ */
+struct ufshcd_res_info_t {
+ const char *name;
+ struct resource *resource;
+ void __iomem *base;
+};
Please remove the suffix "_t" since that suffix is typically used for
typedefs and not for data structures.
Thanks,
Bart.
