On 9/22/22 18:05, Asutosh Das wrote:
+static int ufshcd_mcq_config_nr_queues(struct ufs_hba *hba)
+{
+ int i, rem;
+ u32 hbaq_cap, cmp, tot_queues;
+ struct Scsi_Host *host = hba->host;
+
+ hbaq_cap = hba->mcq_capabilities & 0xff;
+
+ if (!rw_queues)
+ rw_queues = num_possible_cpus();
+
+ tot_queues = dev_cmd_queue + read_queues + poll_queues + rw_queues;
+ if (hbaq_cap < tot_queues) {
+ dev_err(hba->dev, "Total queues (%d) exceeds HC capacity (%d)\n",
+ tot_queues, hbaq_cap);
+ return -EOPNOTSUPP;
+ }
+
+ rem = hbaq_cap - dev_cmd_queue;
+ cmp = rem;
+ hba->nr_queues[HCTX_TYPE_DEFAULT] = min3(cmp, rw_queues,
+ num_possible_cpus());
+ rem -= hba->nr_queues[HCTX_TYPE_DEFAULT];
+ cmp = rem;
+ hba->nr_queues[HCTX_TYPE_POLL] = min(cmp, poll_queues);
+ rem -= hba->nr_queues[HCTX_TYPE_POLL];
+ cmp = rem;
+ hba->nr_queues[HCTX_TYPE_READ] = min(cmp, read_queues);
+
+ for (i = 0; i < HCTX_MAX_TYPES; i++)
+ host->nr_hw_queues += hba->nr_queues[i];
+
+ hba->nr_hw_queues = host->nr_hw_queues + dev_cmd_queue;
+ return 0;
+}
Please consider removing the variable 'cmp' and instead use min_t() or a
type cast.
Thanks,
Bart.
