Re: [PATCH v2 6/8] scsi: libsas: use sas_phy_match_dev_addr() instead of open coded

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2022/9/26 19:43, John Garry wrote:
On 24/09/2022 08:34, Jason Yan wrote:
@@ -2115,8 +2109,7 @@ int sas_find_attached_phy(struct expander_device *ex_dev,
      for (phy_id = 0; phy_id < ex_dev->num_phys; phy_id++) {
          phy = &ex_dev->ex_phy[phy_id];
-        if (SAS_ADDR(phy->attached_sas_addr)
-            == SAS_ADDR(dev->sas_addr))
+        if (sas_phy_match_dev_addr(dev, phy))

It would be nice if the series was arranged such that sas_phy_match_dev_addr() is available when you introduce sas_phy_match_dev_addr()


I assume you mean sas_phy_match_dev_addr() should available before introducing sas_find_attached_phy().

Yes, I can make that change.

Thanks,
Jason


              return phy_id;
      }

Thanks,
John
.



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux