Re: [PATCH v2 5/8] scsi: libsas: introduce sas address comparation helpers

[Jason Yan <yanaijie@xxxxxxxxxx>]

On 2022/9/26 19:44, John Garry wrote:
> On 24/09/2022 08:34, Jason Yan wrote:
> > +static inline bool sas_phy_match_dev_addr(struct domain_device *dev,
> > +                     struct ex_phy *phy)
> > +{
> > +    return SAS_ADDR(dev->sas_addr) == SAS_ADDR(phy->attached_sas_addr);
> > +}
> > +
> > +static inline bool sas_phy_match_port_addr(struct asd_sas_port *port,
> > +                       struct ex_phy *phy)
> > +{
> > +    return SAS_ADDR(port->sas_addr) == SAS_ADDR(phy->attached_sas_addr);
> > +}
> > +
> > +static inline bool sas_phy_addr_same(struct ex_phy *p1, struct ex_phy 
> > *p2)
>
> nit: please use "match" or "same" consistently in the naming. My 
> preference was for "match" to be used.

OK.

Thanks,
Jason

> Thanks,
> John
>
> > +{
> > +    return  SAS_ADDR(p1->attached_sas_addr) == 
> > SAS_ADDR(p2->attached_sas_addr);
> > +}
> > +
>
> .