On 8/15/22 1:35 AM, Dmitry Bogdanov wrote: > On Fri, Aug 12, 2022 at 01:12:12PM -0500, michael.christie@xxxxxxxxxx wrote: >> >> On 8/12/22 6:34 AM, Dmitry Bogdanov wrote: >>> On Thu, Aug 11, 2022 at 10:43:24PM -0500, Mike Christie wrote: >>>> >>>> On 7/18/22 7:01 AM, Dmitry Bogdanov wrote: >>>>> Make support of RSOC turned off by emulate_rsoc attibute. >>>>> >>>> >>>> What was the reason for this? >>> Looks like, it was by analogue to other emulate_* attibutes. But >>> actually RSOC itself is independent to a backstore device, so better to >>> drop this patch :) >> >> I was actually ok with it in general. It seemed nice for testing. >> >> I was asking because I thought you hit some regressions when it was >> on and just wanted you add that info to the git commit. > No, there was no regression. > So, better to keep this patch but to add to a commit message, that it > is just for testing purposes? Sorry for the late reply. I was on vacation. Yeah, that seems fine. scsi-ml will take different code paths if RSOC is supported. Other OSs might do the same so it might be useful.