Thanks for reviewing the code, Himanshu. Response inline.. On Mon, 29 Aug 2022, 9:24am, Himanshu Madhani wrote: > Small nits > > > On Aug 26, 2022, at 3:25 AM, Nilesh Javali <njavali@xxxxxxxxxxx> wrote: > > > > From: Arun Easi <aeasi@xxxxxxxxxxx> > > > > Older tracing of driver messages was to: > > - log only debug messages to kernel main trace buffer AND > > - log only if extended logging bits corresponding to this > > message is off > > > > This has been modified and extended as follows: > > - Tracing is now controlled via ql2xextended_error_logging_ktrace > > module parameter. Bit usages same as ql2xextended_error_logging. > > - Tracing uses "qla2xxx" trace instance, unless instance creation > > have issues. > > - Tracing is enabled (compile time tunable). > > - All driver messages, include debug and log messages are now traced > > in kernel trace buffer. > > > > Trace messages can be viewed by looking at the qla2xxx instance at: > > /sys/kernel/tracing/instances/qla2xxx/trace > > > ^^^^^^^^ > This should be /sys/kernel/debug/tracing/instances/qla2xxx/trace > With tracefs, the location is moved to: /sys/kernel/tracing ..with old location preserved. Regards, -Arun PS: # grep -A 10 '^The File System' Documentation/trace/ftrace.rst
