--- adam radford wrote: > I have one problem with this patch: > > You are calling "class_device_create()" from 0 to "TW_MAX_UNITS" > which is 16... > shouldn't you be calling this only once per each controller instance > that is discovered > via twa_probe() ? Well, I was just trying to emulate what the userspace tools do, which is create all 16 devices whether or not they're physically present. I actually tried with only twe0 (I have only one card in my test system) and smartd seems to try to find twe1-15 anyway. I'm not sure what it's doing, but I assume it's talking to the driver. > Also, no other scsi LLDD drivers are calling "class_device_create()", > so I wonder if > this is acceptable to scsi maintainers? I wondered the same thing. I think perhaps the only issue is with SELinux mentioned below which is rare and so it's a low priority to use sysfs. There may be other reasons I'm not aware of, though. > Right now we have our userspace tools creating the /dev/tweX devices. Yes, unfortunately that leaves the /dev/tweX devices with the wrong SELinux security context and harald@redhat suggested this approach: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232218 I'd be happy to hear alternative solutions, but it sounds like they do not want to use a custom udev rule. ____________________________________________________________________________________ Get the free Yahoo! toolbar and rest assured with the added security of spyware protection. http://new.toolbar.yahoo.com/toolbar/features/norton/index.php - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
