On 7/6/07, Joshua Daniel Franklin <joshuadfranklin@xxxxxxxxx> wrote:
Add tw_sysfs_init() to register 3w-xxxx driver with sysfs. This also causes udev to create /dev/twe* devices with the correct SELinux security context. Signed-off-by: Joshua Daniel Franklin <joshuadfranklin@xxxxxxxxx>
Thanks for the patch. I have one problem with this patch: You are calling "class_device_create()" from 0 to "TW_MAX_UNITS" which is 16... shouldn't you be calling this only once per each controller instance that is discovered via twa_probe() ? Also, no other scsi LLDD drivers are calling "class_device_create()", so I wonder if this is acceptable to scsi maintainers? Right now we have our userspace tools creating the /dev/tweX devices. -Adam - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
