On 3/8/22 08:48, Damien Le Moal wrote: > This series fix (remove) all sparse warnings generated when compiling > the mpt3sas driver. All warnings are related to __iomem access and > endianness. > > The series was tested on top of Martin's 5.18/scsi-staging branch with a > 9400-8i HBA with direct attached iSAS and SATA drives. The fixes need > careful review by the maintainers as there is no documentation clearly > explaning the proper endianness of the values touched. Martin, Can we get this one queued for 5.19 ? > > Changes from v2: > * Reworked patch 5 to keep writel() calls. Sparse warnings are > suppressed with a declaration fix. > > Changes from v1: > * Reworked patch 1 to remove the TaskMID field type change and simplify > _ctl_set_task_mid() code. > > Damien Le Moal (5): > scsi: mpt3sas: fix _ctl_set_task_mid() TaskMID check > scsi: mpt3sas: Fix writel() use > scsi: mpt3sas: fix ioc->base_readl() use > scsi: mpt3sas: fix event callback log_code value handling > scsi: mpt3sas: fix adapter replyPostRegisterIndex declaration > > drivers/scsi/mpt3sas/mpt3sas_base.c | 32 ++++++++++++++-------------- > drivers/scsi/mpt3sas/mpt3sas_base.h | 2 +- > drivers/scsi/mpt3sas/mpt3sas_ctl.c | 11 +++++----- > drivers/scsi/mpt3sas/mpt3sas_scsih.c | 6 +++--- > 4 files changed, 26 insertions(+), 25 deletions(-) > -- Damien Le Moal Western Digital Research