> On Wed, 2022-04-20 at 14:31 +0900, Keoseong Park wrote: > > > > > > + /* > > > + * Remove this region from active region list and add it > > > to inactive list > > > + */ > > > + spin_lock(&hpb->rsp_list_lock); > > > + ufshpb_update_inactive_info(hpb, region_index); > > How about separating the "hpb->stats.rb_inactive_cnt++" code from > > ufshpb_update_inactive_info()? > > Because I think this code should only be used in > > ufshpb_rsp_req_region_update(). Hi Keoseong Park, I didn't take this hpb->stats.rb_inactive_cnt++ out, since I think if the host receives HPB operation:02h, which means the device recommends the host to de-activate all active regions on the host side. we need to add these de-activations to this parameter because the device has inactivated all active regions. Otherwise, we will find an inconsistent inactivation and activation counter. Please have a look a review the v3. Kind regards, Bean
