Re: [PATCH] zfcp: Report FCP LUN to SCSI midlayer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Luben Tuikov wrote:
> Display this:
>  "%016llx", ((unsigned long long) be64_to_cpu(*(__be64 *)(LUN))),
> where LUN is u8[8].  Notice the ugly, C-centric "0x" prefix
> is missing.

I agree.  We don't need 0x prefix nor h suffix nor delimiters like
spaces, dashes, colons... in the kernel's printouts of LUNs (i.e. in
sysfs attribute values or sysfs path components or dmesg debug printouts
or wherever the kernel might hand out LUN represemtations to userspace).

...
> This also makes it great to be a directory name, since it is the
> same width and format,
...

Yes, that's quite OK for syfs path components.  But remember that syfs
path components are considered unstable sysfs ABI elements.
-- 
Stefan Richter
-=====-=-=== -==- ==-=-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux