On 16/03/2022 23:03, Bart Van Assche wrote:
[ ... ]
why do you need a separate header file? why not put all this in the
only C file?
The C file is already very big. I like the approach of keeping
declarations and structure definitions in a header file because that
makes the code easier to navigate.
If the file is huge and hard to navigate then I would suggest multiple C
files with a common header file to share defines.
But I don't feel too strongly about that.
However, I would be keen on seeing a leaner driver.
+struct spraid_completion {
+ __le32 result;
I think that __le32 is used for userspace common defines, while we use
le32 for internal to kernel
Really? I'm not aware of a le32 type in the Linux kernel.
That's my mistake - you're right. I was thinking of u32 vs __u32
+#define SPRAID_DRV_VERSION "1.0.0.0"
I don't see much value in driver versioning. As I see, the kernel
version is the driver version.
thanks,
John
