On 3/15/22 07:43, John Garry wrote:
On 14/03/2022 02:53, Yanling Song wrote:
[ ... ]
why do you need a separate header file? why not put all this in the only
C file?
The C file is already very big. I like the approach of keeping
declarations and structure definitions in a header file because that
makes the code easier to navigate.
+struct spraid_completion {
+ __le32 result;
I think that __le32 is used for userspace common defines, while we use
le32 for internal to kernel
Really? I'm not aware of a le32 type in the Linux kernel.
+#define SPRAID_DRV_VERSION "1.0.0.0"
I don't see much value in driver versioning. As I see, the kernel
version is the driver version.
+1
Thanks,
Bart.
