On 24/02/2022 12:43, Damien Le Moal wrote:
On 2/24/22 20:04, John Garry wrote:
Nobody checks the return codes, so make them return void. Indeed, if the
LLDD cannot send an event, nothing much can be done in the LLDD about it.
It really sound like the LLDDs should be fixed to e.g. reset the adapter
if things go south with these functions. No sure though.
But this is not an adapter fault. As an example of a scenario which we
could be dealing with, it may be that a phyup event occurs in the
adapter but libsas cannot allocate memory to process the event. There's
not much the adapter/LLDD can do about that (nor does do).
Also remove prototype for sas_notify_phy_event() in sas_internal.h, which
should not be there.
Signed-off-by: John Garry <john.garry@xxxxxxxxxx>
Reviewed-by: Xiang Chen <chenxiang66@xxxxxxxxxxxxx>
In any case, these changes do not make anything worse :)
Thanks,
Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
